openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Need to look at the UI !
As a general point we should not mix reformatting and code changes but that needs to be ratified!.

241-242 and 243-244 should be one line.

401-402 some line or 402 should be extra tab

554 should the regex be compiled into the CLASS once?

As a side note it was discussed whether this was to be in Settings when it was designed and it was considered not the be a settings dialogue.  That was 2-3 years ago though.


-- 
https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140176
Your team OpenLP Core is subscribed to branch lp:openlp.