← Back to team overview

openlp-core team mailing list archive

[Bug 1099112] [NEW] Crash on reading invalid theme file

 

Public bug reported:

When OpenLP starts up, it reads all theme files. If one of those files
was corrupted in some way, like a failed download, OpenLP will crash
when started up.

2013-01-13 01:13:13,717 openlp.core.ui.thememanager                             DEBUG    Unzipping theme C:\Users\keith\AppData\Roaming\openlp\data\themes\Moss_on_tree.otz
2013-01-13 01:13:13,719 openlp.core.ui.thememanager                             ERROR    Importing theme from zip failed C:\Users\keith\AppData\Roaming\openlp\data\themes\Moss_on_tree.otz
Traceback (most recent call last):
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 541, in unzipTheme
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 714, in __init__
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 748, in _GetContents
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 763, in _RealGetContents
BadZipfile: File is not a zip file
2013-01-13 01:13:13,719 root                                                    ERROR    Traceback (most recent call last):
  File "<string>", line 44, in <module>
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core", line 344, in main
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core", line 150, in run
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.mainwindow", line 717, in __init__
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 449, in loadThemes
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 162, in firstTime
  File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 586, in unzipTheme
Exception: validation
None

OpenLP 2.0.1
Windows 7 Home Premium 64-bit
Open Office 3

Note: I'm reporting this because someone asked about it on IRC. Haven't
tried to reproduce it yet.

** Affects: openlp
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1099112

Title:
  Crash on reading invalid theme file

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  When OpenLP starts up, it reads all theme files. If one of those files
  was corrupted in some way, like a failed download, OpenLP will crash
  when started up.

  2013-01-13 01:13:13,717 openlp.core.ui.thememanager                             DEBUG    Unzipping theme C:\Users\keith\AppData\Roaming\openlp\data\themes\Moss_on_tree.otz
  2013-01-13 01:13:13,719 openlp.core.ui.thememanager                             ERROR    Importing theme from zip failed C:\Users\keith\AppData\Roaming\openlp\data\themes\Moss_on_tree.otz
  Traceback (most recent call last):
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 541, in unzipTheme
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 714, in __init__
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 748, in _GetContents
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\zipfile", line 763, in _RealGetContents
  BadZipfile: File is not a zip file
  2013-01-13 01:13:13,719 root                                                    ERROR    Traceback (most recent call last):
    File "<string>", line 44, in <module>
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core", line 344, in main
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core", line 150, in run
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.mainwindow", line 717, in __init__
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 449, in loadThemes
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 162, in firstTime
    File "D:\OpenLP_Code\release-2.0.1\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.ui.thememanager", line 586, in unzipTheme
  Exception: validation
  None

  OpenLP 2.0.1
  Windows 7 Home Premium 64-bit
  Open Office 3

  Note: I'm reporting this because someone asked about it on IRC.
  Haven't tried to reproduce it yet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1099112/+subscriptions


Follow ups

References