openlp-core team mailing list archive

[mohij <patrick@xxxxxxxxx>]

> Don't use "Diable bla bla bla" in checkboxes. I have to enable a checkbox to
> disable something?
> 
> 1) Should be "Enable alternating row colors in lists".
> 2) Please used --fixes lp:#<bug-number-here> when committing. Also assign
> yourself to the bug you are fixing:
> https://bugs.launchpad.net/openlp/+bug/936281
> 
> Regards

I disagree in both points.
1) It's about workarounds here. They are listed in a workarounds group box and I think it makes more sense having to tick them to enable the workaround. In this case enabling the workaround means disabling alternating row colors.
2) This branch does not completely fix bug 936281. Even though that report is a result of my inital forum post, it describes a different problem than I am fixing here. The name of the branch is misleading, should I perhaps rename it?
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/143032
Your team OpenLP Core is subscribed to branch lp:openlp.