← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

 

Review: Needs Fixing

1381,2,3 please change the Event handlers

QtCore.QObject.connect(self.listView, QtCore.SIGNAL(u'doubleClicked(QModelIndex)'),
self.onDoubleClicked)

QtCore.QObject.connect(self.listView, QtCore.SIGNAL(u'itemSelectionChanged()'),
self.onSelectionChange)

QtCore.QObject.connect(self.listView, QtCore.SIGNAL(u'customContextMenuRequested(QPoint)'),
 self.contextMenu)

to 
self.listView.doubleClicked.connect(self.on_double_clicked)
self.listView.itemSelectionChanged.connect(self.on_selection_change)
self.listView.customContextMenuRequested.connect(self.contextMenu)
-- 
https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/146318
Your team OpenLP Core is subscribed to branch lp:openlp.


References