← Back to team overview

openlp-core team mailing list archive

[Bug 1135392] [NEW] Catch all error trap in editsongform.py, _processLyrics

 

Public bug reported:

Hi,

I have been investigating a bug that has been reported on the support
tracker (http://support.openlp.org/issues/1906) and I have traced it
back to http://bazaar.launchpad.net/~openlp-
core/openlp/release-2.0/view/head:/openlp/plugins/songs/forms/editsongform.py#L941

I have seen reports like this before on the support tracker, but have
only just been able to narrow it down thanks to this comment:
https://bugs.launchpad.net/openlp/+bug/1051890/comments/4 by Jonathan

It appears that this catch all maybe responsible for us being unable to
fix several different bugs.

So as Jonathan says: 
" We shouldn't ignore/hide these errors, and ideally want to fix the original cause." 
"Either that or re-throw the error"

I've created this separate report as Jonathan's comments were kind of
hidden, but to me seem quite important.

** Affects: openlp
     Importance: High
         Status: Confirmed

** Affects: openlp/2.0
     Importance: High
         Status: Confirmed

** Affects: openlp/trunk
     Importance: High
         Status: Confirmed


** Tags: song support-system

** Also affects: openlp/2.0
   Importance: Undecided
       Status: New

** Also affects: openlp/trunk
   Importance: High
       Status: Confirmed

** Changed in: openlp/2.0
    Milestone: None => 2.0.2

** Changed in: openlp/trunk
    Milestone: None => 2.1.1

** Changed in: openlp/2.0
   Importance: Undecided => High

** Changed in: openlp/2.0
       Status: New => Confirmed

** Tags added: song support-system

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1135392

Title:
  Catch all error trap in editsongform.py, _processLyrics

Status in OpenLP - Worship Presentation Software:
  Confirmed
Status in OpenLP 2.0 series:
  Confirmed
Status in OpenLP trunk series:
  Confirmed

Bug description:
  Hi,

  I have been investigating a bug that has been reported on the support
  tracker (http://support.openlp.org/issues/1906) and I have traced it
  back to http://bazaar.launchpad.net/~openlp-
  core/openlp/release-2.0/view/head:/openlp/plugins/songs/forms/editsongform.py#L941

  I have seen reports like this before on the support tracker, but have
  only just been able to narrow it down thanks to this comment:
  https://bugs.launchpad.net/openlp/+bug/1051890/comments/4 by Jonathan

  It appears that this catch all maybe responsible for us being unable
  to fix several different bugs.

  So as Jonathan says: 
  " We shouldn't ignore/hide these errors, and ideally want to fix the original cause." 
  "Either that or re-throw the error"

  I've created this separate report as Jonathan's comments were kind of
  hidden, but to me seem quite important.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1135392/+subscriptions


Follow ups

References