openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

As Phil identified, the object name needs to be the same:

21	+ self.display_verse_check_box.setObjectName(u'verse_display_check_box')

Line 51 doesn't need to be blank. It's a short method, you're not increasing readability by adding it.

For any code that is committed to lp:openlp, we need at least 1 test committed. This does not need to be related to the change you made (though it would be nice), just as long is it is present. This way we can slowly but surely increase test coverage of OpenLP.
-- 
https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179610
Your team OpenLP Core is subscribed to branch lp:openlp.