openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

47	+Provide a work around for a bug in QFileDialog (#1209515)

Can you just be specific and say this is for a Launchpad bug (I might think it is a PyQt4 bug).

63	+ file_list = QtCore.QStringList()
73	+ file_list.append(QtCore.QString(file))

Why? This is Python, use Python objects.

106	+ self.FNFT = unicode(translate('OpenLP.Ui',
108	+ self.FNF = unicode(translate('OpenLP.Ui',

What does FNFT and FNF mean? I would prefer self.FileNotFound and self.FileNotFoundMessage

109	+ 'File %s not found.\nPlease try selecting it individually.'))

This is horrible. Is there truly no way we can fix this problem?
-- 
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/179976
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.