openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxxxxxxx>]

> 63      + file_list = QtCore.QStringList()
> 73      + file_list.append(QtCore.QString(file))
>
> Why? This is Python, use Python objects.
As I was reimplementing and creating a "slot in" method I wanted to keep the same return type. But if you'd rather I'd use python objects I can. Also should I change the method name from camel case?

Note in the trunk version I have used python objects as we use PyQt API v2 (which automatically casts to python objects)

>
> 106     + self.FNFT = unicode(translate('OpenLP.Ui',
> 108     + self.FNF = unicode(translate('OpenLP.Ui',
>
> What does FNFT and FNF mean? I would prefer self.FileNotFound and self.FileNotFoundMessage

Sure, I was just following convention of the other variables.

> 109     + 'File %s not found.\nPlease try selecting it individually.'))
>
> This is horrible. Is there truly no way we can fix this problem?

Agreed, I included this as a belt and braces approach. I have tested this code with around 2000 files and have not seen this dialogue. I just added it because o wasn't 100% sure we might not have other encoding issues.

The bug is in Qt, select a single file and its fine, but select multiple files and it seems to URL encode the names. I don't see any other way round this!
-- 
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/179976
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.