← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~whydoubt/openlp/propresenter into lp:openlp

 

Have you provided some sample songs?

tests/functional/openlp_plugins/songs/test_songshowplusimport.py in my branch ~phill-ridout/openlp/song_helper is probably the best example of importer tests I have written. Once its merged you should be able to use the SongImportTestHelper class to simplify the testing of the complete import process.

Create a folder in tests/resources/ and pick a couple of Public Domain songs (with vairous features such as different verse types, maybe a verse order, several authors etc. and save the results as a json file see one of the files in tests/resources/songshowplussongs/ for an example. 

You still should provide unit tests for your methods too.

http://wiki.openlp.org/Development:Unit_Tests should be of some help. If you need any more just ping me on IRC 
-- 
https://code.launchpad.net/~whydoubt/openlp/propresenter/+merge/183569
Your team OpenLP Core is subscribed to branch lp:openlp.


References