← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~marmyshev/openlp/full_background_audio into lp:openlp

 

Review: Needs Fixing

Need to understand  how this differs from song audio.
Plugin code cannot be used in core.
Many formatting errors commented code spaces etc.
No tests
Need to look at service manager but there is no list space so need to thing again
What happens with a song that has background music as well?

-- 
https://code.launchpad.net/~marmyshev/openlp/full_background_audio/+merge/185998
Your team OpenLP Core is subscribed to branch lp:openlp.


References