openlp-core team mailing list archive

[Oliver Wieland <oli@xxxxxxxxxxxxxxx>]

Oliver Wieland has proposed merging lp:~oliwee/openlp/bug-1247025 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1247025 in OpenLP: "Wrong position when drag and drop an item in the service list"
  https://bugs.launchpad.net/openlp/+bug/1247025

For more details, see:
https://code.launchpad.net/~oliwee/openlp/bug-1247025/+merge/193575

Fixes bug #1247025
Changes the position where a new item will be inserted in the service list via drag'n'drop

Example: service list
A
B
C

item D will be dropped on B's position:
A
B D
C

Before:
A
B
D
C

After:
A
D
B
C
-- 
https://code.launchpad.net/~oliwee/openlp/bug-1247025/+merge/193575
Your team OpenLP Core is requested to review the proposed merge of lp:~oliwee/openlp/bug-1247025 into lp:openlp.

=== modified file 'openlp/core/ui/servicemanager.py'
--- openlp/core/ui/servicemanager.py	2013-10-13 21:07:28 +0000
+++ openlp/core/ui/servicemanager.py	2013-11-01 10:48:29 +0000
@@ -1480,7 +1480,7 @@
                             item.setSelected(True)
                             replace = True
                     else:
-                        self.drop_position = self._get_parent_item_data(item)
+                        self.drop_position = self._get_parent_item_data(item) - 1
                 Registry().execute('%s_add_service_item' % plugin, replace)
 
     def update_theme_list(self, theme_list):