openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~oliwee/openlp/bug-1247025 into lp:openlp

To: mp+193575@xxxxxxxxxxxxxxxxxx
From: Oliver Wieland <oli@xxxxxxxxxxxxxxx>
Date: Fri, 01 Nov 2013 10:53:58 -0000
In-reply-to: <20131101105136.18834.2185.launchpad@ackee.canonical.com>
Reply-to: mp+193575@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

This merge proposal works on all positions in the service list, but not on position '0'. This is because in servicemananager.py. line 1300, the position 0 will be handled in a special way.
But I have no idea when this case would be true (without my changes). Could somebody please explain if this case becomes true at all?
-- 
https://code.launchpad.net/~oliwee/openlp/bug-1247025/+merge/193575
Your team OpenLP Core is requested to review the proposed merge of lp:~oliwee/openlp/bug-1247025 into lp:openlp.

References

[Merge] lp:~oliwee/openlp/bug-1247025 into lp:openlp
From: Oliver Wieland, 2013-11-01