openlp-core team mailing list archive

[Samuel Mehrbrodt <s.mehrbrodt@xxxxxxxxx>]

> Since I live in a small country where english isn't an official language and we don't dub movies I disagree about disabling subtitle selecting.
I didn't mean that the option should be removed. Just that no subtitle is selected by default. Maybe we could enhance this: If there is audio available in the users language, preselect that and select no subtitle by default. Else preselect the subtitle in the users language.

> I played around with this but could not make it work. Looking at VLC's guesses for optical devices I actually prefer the solution in the current code. Do you get false positives?
No, but the device is only shown when there is a media inserted. When there is no media and I insert one, I have to reopen the dialog to get it shown.

> The next question is if there should be some fastforward/backward buttons, and what should they actually do? Skip 1 minute, 30 sec, 10 sec? Or just play at double speed? Or should shortcut keys like "right arrow = skip 10 sec" and "right arrow + shift = skip 1 minute" be added?
Hm I'm not sure if we need that. Maybe for the initial version just play/pause is enough.
-- 
https://code.launchpad.net/~tomasgroth/openlp/dvd/+merge/209347
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/dvd into lp:openlp.