openlp-core team mailing list archive

[Samuel Mehrbrodt <s.mehrbrodt@xxxxxxxxx>]

Review: Needs Fixing

Looks good.

In the tests: Can you for example instead of 'assert result is True' use 'self.assertTrue(result)' as the other tests do?
Here's a list of assert methods: https://docs.python.org/3.4/library/unittest.html#assert-methods
-- 
https://code.launchpad.net/~strada/openlp/songbeamer-import-enhancements/+merge/215578
Your team OpenLP Core is requested to review the proposed merge of lp:~strada/openlp/songbeamer-import-enhancements into lp:openlp.