openlp-core team mailing list archive

[Stefan Strasser <strada@xxxxxxxxxxx>]

Hello Samuel

Thanks for your feedback.

I've looked at the openlp-wiki about writing unittests [1], my 'assert 
result is True' comes from there.

Changing my code I stumbled upon the following:
- the already existing test-functions in the testfile concerned use 
assertEquals(), which is a deprecated alias since about python 3.1 
(however it still works); I'll change all occurrences of assertEquals in 
the file to assertEqual, ok?
- to function assertIsNone() to be used instead of 'assert result is 
None' has been introduced with python 3.1, a test with this function 
will therefore not work with python 3.0; is this a problem? The only 
minimum-version I've found in the wiki is the statement that openlp is 
being written in python 3.

kind regards,
Stefan Strasser

[1] http://wiki.openlp.org/Development:Unit_Tests


Am 14.04.2014 13:01, schrieb Samuel Mehrbrodt:
> Review: Needs Fixing
>
> Looks good.
>
> In the tests: Can you for example instead of 'assert result is True' use 'self.assertTrue(result)' as the other tests do?
> Here's a list of assert methods: https://docs.python.org/3.4/library/unittest.html#assert-methods


-- 
https://code.launchpad.net/~strada/openlp/songbeamer-import-enhancements/+merge/215578
Your team OpenLP Core is requested to review the proposed merge of lp:~strada/openlp/songbeamer-import-enhancements into lp:openlp.