← Back to team overview

openlp-core team mailing list archive

[Bug 1312629] [NEW] Error on entering invalid character in verse-order

 

Public bug reported:

Ubuntu 13.04
OpenLP trunk rev 2369 (does not occur on version 2.04)

An error occurs if in verse-order a non-existing tag/abbreviation is
entered.

1) create a new song
2) edit the verse-order
3) enter a random char which is not an abbreviation for a verse-type in the current language (like 'q' or 'x' in english)
4) error-popup with traceback occurs

Entering a tag/abbreviation for a valid versetype which is not currently
existing in the song does not lead to this error (is checked and
notified on saving).

Traceback (most recent call last):
  File "~/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 723, in on_verse_order_text_changed
    verses_in_order = self._extract_verse_order(self.verse_order_edit.text())
  File "~/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 144, in _extract_verse_order
    verse_index = VerseType.from_translated_tag(item, None)
  File "~/openlp/trunk/openlp/plugins/songs/lib/__init__.py", line 234, in from_translated_tag
    if len(VerseType.names) > default:
TypeError: unorderable types: int() > NoneType()

** Affects: openlp
     Importance: Undecided
     Assignee: Stefan Strasser (strada)
         Status: New

** Changed in: openlp
     Assignee: (unassigned) => Stefan Strasser (strada)

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1312629

Title:
  Error on entering invalid character in verse-order

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  Ubuntu 13.04
  OpenLP trunk rev 2369 (does not occur on version 2.04)

  An error occurs if in verse-order a non-existing tag/abbreviation is
  entered.

  1) create a new song
  2) edit the verse-order
  3) enter a random char which is not an abbreviation for a verse-type in the current language (like 'q' or 'x' in english)
  4) error-popup with traceback occurs

  Entering a tag/abbreviation for a valid versetype which is not
  currently existing in the song does not lead to this error (is checked
  and notified on saving).

  Traceback (most recent call last):
    File "~/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 723, in on_verse_order_text_changed
      verses_in_order = self._extract_verse_order(self.verse_order_edit.text())
    File "~/openlp/trunk/openlp/plugins/songs/forms/editsongform.py", line 144, in _extract_verse_order
      verse_index = VerseType.from_translated_tag(item, None)
    File "~/openlp/trunk/openlp/plugins/songs/lib/__init__.py", line 234, in from_translated_tag
      if len(VerseType.names) > default:
  TypeError: unorderable types: int() > NoneType()

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1312629/+subscriptions


Follow ups

References