openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #23522
[Bug 1310523] Re: Can't display songs that have more than 26 verses named equally
** Changed in: openlp/trunk
Status: In Progress => Fix Committed
** Changed in: openlp/2.0
Milestone: 2.1.1 => 2.0.5
** Changed in: openlp/trunk
Milestone: 2.0.5 => 2.1.1
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1310523
Title:
Can't display songs that have more than 26 verses named equally
Status in OpenLP - Worship Presentation Software:
Fix Committed
Status in OpenLP 2.0 series:
In Progress
Status in OpenLP trunk series:
Fix Committed
Bug description:
Reported here: http://support.openlp.org/scp/tickets.php?id=2313
The problem is that if we have multiple verses with the same name a letter will be appended to them according to the OpenLyrics specification (eg. v1,v1,v1 becomes v1a,v1b,v1c.
Now if there are more than 26 verses with the same name, it runs out of characters and takes some weird ones. Then lxml fails to read them.
You get this exception:
Traceback (most recent call last):
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 475, in onDoubleClicked
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 497, in onPreviewClick
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 591, in buildServiceItem
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.mediaitem", line 529, in generateSlideData
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.xml", line 365, in song_to_xml
File "lxml.etree.pyx", line 2145, in lxml.etree._Attrib.__setitem__ (src/lxml/lxml.etree.c:46818)
File "apihelpers.pxi", line 563, in lxml.etree._setAttributeValue (src/lxml/lxml.etree.c:15781)
File "apihelpers.pxi", line 1366, in lxml.etree._utf8 (src/lxml/lxml.etree.c:22211)
ValueError: All strings must be XML compatible: Unicode or ASCII, no NULL bytes or control characters
To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1310523/+subscriptions
References