← Back to team overview

openlp-core team mailing list archive

[Bug 1310523] [NEW] Can't display songs that have more than 26 verses named equally

 

Public bug reported:

Reported here: http://support.openlp.org/scp/tickets.php?id=2313

The problem is that if we have multiple verses with the same name a letter will be appended to them according to the OpenLyrics specification (eg. v1,v1,v1 becomes v1a,v1b,v1c.
Now if there are more than 26 verses with the same name, it runs out of characters and takes some weird ones. Then lxml fails to read them.

You get this exception:

Traceback (most recent call last):
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 475, in onDoubleClicked
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 497, in onPreviewClick
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 591, in buildServiceItem
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.mediaitem", line 529, in generateSlideData
File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.xml", line 365, in song_to_xml
File "lxml.etree.pyx", line 2145, in lxml.etree._Attrib.__setitem__ (src/lxml/lxml.etree.c:46818)
File "apihelpers.pxi", line 563, in lxml.etree._setAttributeValue (src/lxml/lxml.etree.c:15781)
File "apihelpers.pxi", line 1366, in lxml.etree._utf8 (src/lxml/lxml.etree.c:22211)
ValueError: All strings must be XML compatible: Unicode or ASCII, no NULL bytes or control characters

** Affects: openlp
     Importance: Low
     Assignee: Samuel Mehrbrodt (sam92)
         Status: New

** Affects: openlp/2.0
     Importance: Low
     Assignee: Samuel Mehrbrodt (sam92)
         Status: New

** Affects: openlp/trunk
     Importance: Low
     Assignee: Samuel Mehrbrodt (sam92)
         Status: New

** Changed in: openlp
   Importance: Undecided => Low

** Changed in: openlp
     Assignee: (unassigned) => Samuel Mehrbrodt (sam92)

** Changed in: openlp
    Milestone: None => 2.0.5

** Also affects: openlp/2.0
   Importance: Undecided
       Status: New

** Also affects: openlp/trunk
   Importance: Low
     Assignee: Samuel Mehrbrodt (sam92)
       Status: New

** Changed in: openlp/2.0
     Assignee: (unassigned) => Samuel Mehrbrodt (sam92)

** Changed in: openlp/2.0
    Milestone: None => 2.1.1

** Changed in: openlp/2.0
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1310523

Title:
  Can't display songs that have more than 26 verses named equally

Status in OpenLP - Worship Presentation Software:
  New
Status in OpenLP 2.0 series:
  New
Status in OpenLP trunk series:
  New

Bug description:
  Reported here: http://support.openlp.org/scp/tickets.php?id=2313

  The problem is that if we have multiple verses with the same name a letter will be appended to them according to the OpenLyrics specification (eg. v1,v1,v1 becomes v1a,v1b,v1c.
  Now if there are more than 26 verses with the same name, it runs out of characters and takes some weird ones. Then lxml fails to read them.

  You get this exception:

  Traceback (most recent call last):
  File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 475, in onDoubleClicked
  File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 497, in onPreviewClick
  File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.core.lib.mediamanageritem", line 591, in buildServiceItem
  File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.mediaitem", line 529, in generateSlideData
  File "D:\OpenLP_Code\2.0\build\pyi.win32\OpenLP\out00-PYZ.pyz\openlp.plugins.songs.lib.xml", line 365, in song_to_xml
  File "lxml.etree.pyx", line 2145, in lxml.etree._Attrib.__setitem__ (src/lxml/lxml.etree.c:46818)
  File "apihelpers.pxi", line 563, in lxml.etree._setAttributeValue (src/lxml/lxml.etree.c:15781)
  File "apihelpers.pxi", line 1366, in lxml.etree._utf8 (src/lxml/lxml.etree.c:22211)
  ValueError: All strings must be XML compatible: Unicode or ASCII, no NULL bytes or control characters

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1310523/+subscriptions


Follow ups

References