openlp-core team mailing list archive

[Phill <1420276@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Added as a bug to remember things to do after 2.2, please add additional
tasks:

In plugin/songs/lib/openlyricsxml.py:get_verses there is an if statement
with the following comment:

"This is an old style song, without XML. Let's handle it correctly by
iterating through the verses, and then recreating the internal xml
object as well."

This code should be removed as we do not support upgrade paths < 2.0.5

-----------------------------------------------------------------------------

In core/common/settings.py:Settings __obsolete_settings__ has four
settings commented with:

"Changed during 1.9.x development."

This code should be removed as we do not support upgrade paths < 2.0.5

** Affects: openlp
     Importance: Low
         Status: New

** Changed in: openlp
   Importance: Undecided => Low

** Description changed:

  Added as a bug to remember things to do after 2.2, please add additional
  tasks:
  
  In plugin/songs/lib/openlyricsxml.py:get_verses there is an if statement
  with the following comment:
  
  "This is an old style song, without XML. Let's handle it correctly by
  iterating through the verses, and then recreating the internal xml
  object as well."
  
  This code should be removed as we do not support upgrade paths < 2.0.5
+ 
+ 
+ In core/common/settings.py:Settings __obsolete_settings__ has four
+ settings commented with:
+ 
+ "Changed during 1.9.x development."
+ 
+ This code should be removed as we do not support upgrade paths < 2.0.5

** Description changed:

  Added as a bug to remember things to do after 2.2, please add additional
  tasks:
  
  In plugin/songs/lib/openlyricsxml.py:get_verses there is an if statement
  with the following comment:
  
  "This is an old style song, without XML. Let's handle it correctly by
  iterating through the verses, and then recreating the internal xml
  object as well."
  
  This code should be removed as we do not support upgrade paths < 2.0.5
  
+ -----------------------------------------------------------------------------
  
  In core/common/settings.py:Settings __obsolete_settings__ has four
  settings commented with:
  
  "Changed during 1.9.x development."
  
  This code should be removed as we do not support upgrade paths < 2.0.5

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1420276

Title:
  Remove old upgrade code in
  plugin/songs/lib/openlyricsxml.py:get_verses

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  Added as a bug to remember things to do after 2.2, please add
  additional tasks:

  In plugin/songs/lib/openlyricsxml.py:get_verses there is an if
  statement with the following comment:

  "This is an old style song, without XML. Let's handle it correctly by
  iterating through the verses, and then recreating the internal xml
  object as well."

  This code should be removed as we do not support upgrade paths < 2.0.5

  -----------------------------------------------------------------------------

  In core/common/settings.py:Settings __obsolete_settings__ has four
  settings commented with:

  "Changed during 1.9.x development."

  This code should be removed as we do not support upgrade paths < 2.0.5

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/1420276/+subscriptions