openlp-core team mailing list archive

[Tomas Groth <tomasgroth@xxxxxxxx>]

Review: Needs Fixing

Hi Jasper - I think this must be your first merge request, right? Welcome onboard! It's always great to see new contributors!
As you probably know we are currently preparing for our 2.2 release, and are in a feature freeze, so your changes might not get merged until after 2.2 is released.

I did some testing of your branch and found an issue. For a song which had a verseorder like this: "C1 C1 V1 V2 V3" the footer looked like "Chorus, 1, 2, 3" for the first 2 slides (the chorus'es), but when I reached the 3rd slide with the first verse it changed to "1, 2, 3" - the chorus disappeared.

You also need to make some tests to prove that your code works as expected. Take a look at the existing tests under the "tests" folder for inspiration.

-- 
https://code.launchpad.net/~jasperge/openlp/versenumbers/+merge/255439
Your team OpenLP Core is requested to review the proposed merge of lp:~jasperge/openlp/versenumbers into lp:openlp.