← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp

To: mp+281702@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <tomasgroth@xxxxxxxx>
Date: Thu, 07 Jan 2016 12:21:38 -0000
In-reply-to: <20160105223039.19416.95584.launchpad@ackee.canonical.com>
Reply-to: mp+281702@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

The "_" method name prefix normally signals that the method is private, and thus shouldn't be called from outside the class. So when making a method a function it should lose the "_" prefix.
-- 
https://code.launchpad.net/~thelinuxguy/openlp/make-methods-static/+merge/281702
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~thelinuxguy/openlp/make-methods-static into lp:openlp
From: Simon Hanna, 2016-01-05