openlp-core team mailing list archive

[Tomas Groth <tomasgroth@xxxxxxxx>]

Review: Needs Fixing

See below...

Diff comments:

> 
> === modified file 'tests/resources/projector/data.py'
> --- tests/resources/projector/data.py	2015-12-31 22:46:06 +0000
> +++ tests/resources/projector/data.py	2016-01-03 08:34:41 +0000
> @@ -29,6 +29,14 @@
>  # Test data
>  TEST_DB = os.path.join('tmp', 'openlp-test-projectordb.sql')

Could you please use mkstemp to create a tmp-file-path that works on all platform? See https://docs.python.org/3/library/tempfile.html#tempfile.mkstemp

>  
> +TEST_SALT = '498e4a67'
> +
> +TEST_PIN = 'JBMIAProjectorLink'
> +
> +TEST_HASH = '5d8409bc1c3fa39749434aa3a5c38682'
> +
> +TEST_CONNECT_AUTHENTICATE = 'PJLink 1 {salt}'.format(salt=TEST_SALT)
> +
>  TEST1_DATA = Projector(ip='111.111.111.111',
>                         port='1111',
>                         pin='1111',


-- 
https://code.launchpad.net/~alisonken1/openlp/ticket-921817/+merge/281478
Your team OpenLP Core is subscribed to branch lp:openlp.