openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Hi Gabriel, thanks for your fix!

As per our merge policy, you need to add at least 1 unit test before we will merge your fix. You can read up on unit tests on our wiki:

  http://wiki.openlp.org/Development:Unit_Tests

In addition to that, you need to run the code through Jenkins and present the output. If either the functional or the interface tests break, you need to fix them before continuing.

  http://wiki.openlp.org/Development:Running_Tests


-- 
https://code.launchpad.net/~gabriel-loo/openlp/songselectimportfix/+merge/292045
Your team OpenLP Core is subscribed to branch lp:openlp.