openlp-core team mailing list archive

[Tomas Groth <second@xxxxxx>]

Review: Needs Fixing

Generally it look ok, but please fix the TODO marked below...

Diff comments:

> 
> === modified file 'openlp/core/lib/projector/pjlink1.py'
> --- openlp/core/lib/projector/pjlink1.py	2016-12-31 11:01:36 +0000
> +++ openlp/core/lib/projector/pjlink1.py	2017-05-12 10:04:09 +0000
> @@ -681,6 +715,7 @@
>  
>          :param data: Currently selected source
>          """
> +        # TODO: Class 2 change: verify input does not exceed 95 bytes

Why not just check for it now? Merging in TODO's in trunk is not a great idea...

>          self.source = data
>          log.info('({ip}) Setting data source to "{data}"'.format(ip=self.ip, data=self.source))
>          return


-- 
https://code.launchpad.net/~alisonken1/openlp/pjlink2-a/+merge/323966
Your team OpenLP Core is subscribed to branch lp:openlp.