openlp-core team mailing list archive

[Ken Roberts <alisonken1@xxxxxxxxx>]

At this time, I'm making incremental changes to the projector code.
During this update, there will be some (apparently) minor changes to
some options/commands that are both Class 1 and Class 2 commands, but
_may_ have greater-than-minor impact to the actual code.

In going through the Class 1 to Class 2 changes, I have to verify that
the changes in Class 2 commands that are still Class 1 compatible do
not affect Class 1 projectors.

The TODO notes I'm putting in are reminders that I have to go back and
validate that Class 2 changes do not affect Class 1 projectors, or
conversely that any changes I make for Class 2 do not overly
complicate the process of verifying whether the Class 1 command v.
Class 2 command.

As far as making the changes now, there are some other areas that will
require restructuring in order to accommodate Class 2 upgrades which
will, in turn, require regression checks against Class 1 projectors.


On Mon, May 15, 2017 at 6:28 AM, Tomas Groth <second@xxxxxx> wrote:
> Review: Needs Fixing
>
> Generally it look ok, but please fix the TODO marked below...
>
> Diff comments:
>
>>
>> === modified file 'openlp/core/lib/projector/pjlink1.py'
>> --- openlp/core/lib/projector/pjlink1.py      2016-12-31 11:01:36 +0000
>> +++ openlp/core/lib/projector/pjlink1.py      2017-05-12 10:04:09 +0000
>> @@ -681,6 +715,7 @@
>>
>>          :param data: Currently selected source
>>          """
>> +        # TODO: Class 2 change: verify input does not exceed 95 bytes
>
> Why not just check for it now? Merging in TODO's in trunk is not a great idea...
>
>>          self.source = data
>>          log.info('({ip}) Setting data source to "{data}"'.format(ip=self.ip, data=self.source))
>>          return
>
>
> --
> https://code.launchpad.net/~alisonken1/openlp/pjlink2-a/+merge/323966
> You are the owner of lp:~alisonken1/openlp/pjlink2-a.



-- 
- Ken
Registered Linux user 296561
Slackin' since 1993
Slackware Linux (http://www.slackware.com)
OpenLP - Church Projection Software
Empower Your Church http://openlp.org

https://code.launchpad.net/~alisonken1/openlp/pjlink2-a/+merge/323966
Your team OpenLP Core is subscribed to branch lp:openlp.