openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/pathlib into lp:openlp

To: Raoul Snyman <raoul@xxxxxxxxxxx>
From: Phill <phill.ridout@xxxxxxxxx>
Date: Fri, 07 Jul 2017 08:34:08 -0000
In-reply-to: <149921208809.24646.12131147506682881639.codereview@soybean.canonical.com>
Reply-to: mp+326416@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> We resolved the pathlib issues to an older Python 3.4 installation. We're
> likely moving to min 3.5 soon too, which will further resolve the issues.
> 
> Please don't use pathlib2, just pathlib from Python's library (we chatted
> about this already, just re-iterating it for the benefit of everyone).
> 
> In some earlier or other code, I saw "import pathlib", please just make sure
> you stick to the "from pathlib import Path" form (I do see the correct form in
> here though).
> 
> There are some comments. Please take a look.

Thanks, I'm still working on it and have plenty still to do!
-- 
https://code.launchpad.net/~phill-ridout/openlp/pathlib/+merge/326416
Your team OpenLP Core is subscribed to branch lp:openlp.