← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~bastian-germann/openlp/setup into lp:openlp

 

> Please removed all pymediainfo changes as the media code is been extensively
> refactored and this will cause issues when that is merged.  Your changes have
> been taken on board but implemented differently.

Did you get the latest utf8 decoding change in 2860? I will remove the changes in the next merge proposal.

> Why has run_openlp been restructured instead of just being renamed?

Because setuptools' entry_points needs a function.

> The license file for fonts will be removed at some point as that icon file
> will need to be cleaned up before the release.  We are awaiting a dev to come
> and help with the font UX work.  The fontawsome icons cannot be packaged by
> use.  The only icons are the 10 we have created from scratch.

That is fine. I just added it because the license says it is void if it the license file is not distributed with the font.
-- 
https://code.launchpad.net/~bastian-germann/openlp/setup/+merge/356868
Your team OpenLP Core is subscribed to branch lp:openlp.


References