← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~bastian-germann/openlp/depends into lp:openlp

To: mp+365379@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <second@xxxxxx>
Date: Tue, 02 Apr 2019 10:40:29 -0000
In-reply-to: <155416418259.8111.13371311470441090492.launchpad@ackee.canonical.com>
Reply-to: mp+365379@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

As noted above there is some lint errors that must be fixed.

I noticed you imported qdarkstyle, but it is not used anywhere? I assume it must be activated using a new setting? (I admit I have not run this branch)
-- 
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365379
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~bastian-germann/openlp/depends into lp:openlp
From: Bastian Germann, 2019-04-02