openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Review: Needs Fixing

See inline comment about wrong minimum version of Qt

Diff comments:

> 
> === modified file 'scripts/check_dependencies.py'
> --- scripts/check_dependencies.py	2019-02-14 15:09:09 +0000
> +++ scripts/check_dependencies.py	2019-04-02 00:15:48 +0000
> @@ -40,8 +40,8 @@
>  
>  VERS = {
>      'Python': '3.6',
> -    'PyQt5': '5.5',
> -    'Qt5': '5.5',
> +    'PyQt5': '5.12',
> +    'Qt5': '5.12',

The minimum version should be the version supported by the latest Ubuntu LTS (18.04) and the fedora equivalent. For Ububtu 18.04, this is Qt 5.10 !

>      'pymediainfo': '2.2',
>      'sqlalchemy': '0.5',
>      'enchant': '1.6'


-- 
https://code.launchpad.net/~bastian-germann/openlp/depends/+merge/365379
Your team OpenLP Core is subscribed to branch lp:openlp.