← Back to team overview

openobject-italia-core-devs team mailing list archive

Re: [Merge] lp:~icsergio/openobject-italia/61_imp_withholding_tax into lp:openobject-italia/6.1

 

Review: Needs Information

Hello Sergio.
Could you summarize, in the description, the changes introduced by this MP?
For example, the first improvement
"this implementation uses tax object's and there's no neeed to type the amount of the tax, as it's calculated"
is not valid anymore I think.

Moreover: how can the voucher correctly compute the amount to pay if it doesn't use the 'allocated_amounts_grouped_by_invoice' method? Is it unnecessary? (reference: http://bazaar.launchpad.net/~account-payment-team/account-payment/7.0/view/102/account_voucher_cash_basis/account_voucher.py#L83 )

Thanks!
-- 
https://code.launchpad.net/~icsergio/openobject-italia/61_imp_withholding_tax/+merge/189442
Your team OpenERP Italia core devs is subscribed to branch lp:openobject-italia/6.1.


References