← Back to team overview

openobject-italia-core-devs team mailing list archive

Re: [Merge] lp:~icsergio/openobject-italia/61_imp_withholding_tax into lp:openobject-italia/6.1

 

Riporto qui la risposta

Il 17/10/2013 18:36, Lorenzo Battistini - Agile BG ha scritto:
> On 10/16/2013 11:48 PM, Sergio Corato wrote:
>> I removed dependancies from account_voucher_cash_basis and account_invoice_template (was useful the latter somewhere?)
>
> account_voucher_cash_basis was used to compute the '
> allocated_amounts_grouped_by_invoice', specially in cases of write-off.
> Don't we need to handle write-off?
> Cases of discounts at payments?

Are you sure if we have a discount the amount of withholding tax is lowered too? Without having a regular refund invoice?
Anyone can answer to this question?

Anyway, it's a little modification of the code, if needed.


Will we never have cases of foreign
> currency invoices?
Did you try the module? Have you faced some problem?

>
>
> Moreover, note that if you heavily change a module in a stable version
> (like 6.1 or 7.0), you have to consider what will happen when the new
> version of the module will be installed on a production database with
> the old version in use.
Yeah, I know, it's only for -new- databases and an idea for the next releases.
>
>


-- 
Sergio Corato

https://code.launchpad.net/~icsergio/openobject-italia/61_imp_withholding_tax/+merge/189442
Your team OpenERP Italia core devs is subscribed to branch lp:openobject-italia/6.1.


References