openshot.code team mailing list archive

[noreply@xxxxxxxxxxxxx]

------------------------------------------------------------
revno: 720
committer: Jonathan Thomas <Jonathan.Oomph@xxxxxxxxx>
branch nick: openshot
timestamp: Sat 2012-09-22 17:40:51 -0500
message:
  Fixed a regression with revision 671 and 675, which introduced flashes and glitches at the end of some clips.  Especially when multiple clips were on the same track.
modified:
  openshot/classes/clip.py


--
lp:openshot
https://code.launchpad.net/~openshot.code/openshot/main

Your team OpenShot Code is subscribed to branch lp:openshot.
To unsubscribe from this branch go to https://code.launchpad.net/~openshot.code/openshot/main/+edit-subscription

=== modified file 'openshot/classes/clip.py'
--- openshot/classes/clip.py	2012-09-10 21:28:19 +0000
+++ openshot/classes/clip.py	2012-09-22 22:40:51 +0000
@@ -325,7 +325,7 @@
 		else:
 			# only preview the trimmed clip
 			bg_image.length = self.length()
-		bg_image.max_frames = round(bg_image.length * fps)
+		bg_image.max_frames = round(bg_image.length * fps) - 1
 		bg_clip = clip("Background Clip", "Gold", 0.0, 0.0, bg_image.length, bg_track, bg_image)
 		bg_clip.distort = True
 		bg_clip.fill = True
@@ -420,16 +420,10 @@
 		producer.setAttribute("id", self.unique_id)
 		producer.setAttribute("novdpau", "1")
 		producer.setAttribute("in", str(int(round(in_frame_number))))
-		# need to set the out & length producer properties to prevent odd frame glitches
-		if out_frame_number + 1 >= self.file_object.max_frames:
-			producer.setAttribute("out", str(int(round(self.file_object.max_frames))))	
-		elif (out_frame_number >= self.file_object.max_frames):
-			producer.setAttribute("out", str(int(round(self.file_object.max_frames))))
-		else:
-			producer.setAttribute("out", str(int(round(out_frame_number))))
+		producer.setAttribute("out", str(int(round(out_frame_number))))
 		
 		if self.parent.name != "Background Track":
-			producer.setAttribute("length", str(int(round(self.file_object.max_frames + 1))))
+			producer.setAttribute("length", str((out_frame_number - in_frame_number) + 1))
 
 		# hide video (if needed)
 		if self.play_video == False or self.parent.play_video == False: