← Back to team overview

openshot.developers team mailing list archive

Re: 2 New Commits

 

Hello Jonathan
For me, it a + to know exactly what it 's doing.
Thanks a lot for all this work in more, Olivier

2009/8/21 Jonathan Thomas <jonathan.oomph@xxxxxxxxx>

> I have just deployed reversion 138 and 139 to LaunchPad:
> http://bazaar.launchpad.net/~jonoomph/openshot/main/changes<http://bazaar.launchpad.net/%7Ejonoomph/openshot/main/changes>
>
> To save everyone time, here are the commit messages.  If you find these
> commit messages terribly confusing, please let me know and I can try and
> explain. =)
>
> --------------------------------------
> *Rev 138*
> --------------------------------------
> Fixed the bug where OpenShot crashes when a non-media file is imported.
> Dan helped me fix this one.  We needed to call mlt.Factory.init() each
> time we thumbnail a file.  Then we can use the is_valid() method.  So,
> now OpenShot just ignores invalid files, and it won't crash & seg fault!
>
> Added in a new "lock" class, that ensures that only 1 instance
> of OpenShot can be run at a time.  This has the following features:
>
>  1) Running OpenShot with no command line args (i.e. $ openshot),
>     everything works like normal (the 1st instance of OpenShot to be run
>     will become the "primary instance".
>  2) If you right click on files in Nautilus and open with "openshot",
>     it will pass each file to the primary instance of OpenShot... and
>     the files will appear in the project tree.  This will not create
>     multiple instances of OpenShot
>
> NOTE: You can run multiple version of OpenShot if you don't pass args to
>     the command.
>
> 3) If you pass args to $ openshot "file path 1", "file path 2", "etc", it
>    will add each file to the primary instance of OpenShot
>
> 4) If you just run "$ openshot" over and over again, it will continue to
>    create new instances of OpenShot, so you could work on multiple projects
>    at the same time.  It's only when args are passed along with the
>    "openshot" command that this lock stuff is used.
>
> As part of this new "1 instance" code, there is a new /queue/ folder.  A
> "queue_watcher" thread polls the files in this folder, and when it finds
> any
> file (text files), it cracks them open, reads the path of a file to import,
> imports the file, and then deletes the text file.  The name of the text
> file does not matter.
>
> For example, if you manually create the following files in the /queue/
> folder:
>
> abc123.txt (and it contains:  /home/jonathan/my_video_1.avi)
> def456.txt (and it contains:  /home/jonathan/my_video_2.avi)
>
> The queue_watcher thread should almost instantly delete these 2 text files,
> and then import the 2 files into the primary instance of OpenShot.
> This creates an interesting interface for people to work with, if
> they want to script with OpenShot.
>
> --------------------------------------
> *Rev 139*
> --------------------------------------
> MLT needs to have the Factory re-inited each time we load a
> producer, otherwise it seems less stable... and more likely
> to seg fault.
>
> bumping version to 0.9.25
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> Post to     : openshot.developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers>
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Cenwen un elfe sur la banquise

References