← Back to team overview

openstack-doc-core team mailing list archive

Re: Review Rigour

 

Lots to think about! I appreciate you answering all my questions, Anne.

I like where this is headed, now we have some concrete examples and plans.

Would we be looking at revisiting the Contributor Guidelines in the guide? Or are we going to sort of do this ‘amongst ourselves’?

On 11/17/16, 6:51 AM, "Andreas Jaeger" <aj@xxxxxxxx> wrote:

    On 11/17/2016 04:10 AM, Lana Brindley wrote:
    > On 17/11/16 12:55, Anne Gentle wrote:
    >>
    >>
    >> On Tue, Nov 8, 2016 at 5:42 AM, Alexandra Settle <alexandra.settle@xxxxxxxxxxxxx <mailto:alexandra.settle@xxxxxxxxxxxxx>> wrote:
    >>
    >
    > <snip>
    >
    >>
    >>     Sorry for all the questions! Just many thoughts running through my head. Let it be known that I definitely think this is a good idea! But I suggest some lines are drawn so we are all clearly on the same page.
    >>
    >>
    >> I suggest we try it and see what chaos ensues with these guidelines:
    >> 1. If it's technically accurate, merge it. If it fixes a bug correctly, merge it.
    >> 2. If it's accurate and correct but could be written better, edit, then merge it with a comment to coach the person how the writing could be better.
    >> 3. If it's not the kind of patch we want for the docs, explain that in the review and also follow up to make sure the person doesn't feel rejected outright. Take ownership of the coaching areas more than the "this is wrong and here's why" aspect. (I'm not saying your reviews are like that, mind you, I just want ownership of the growth of contributors and the accurate doc base, not ownership of "it meets our English standards.")
    >>
    >
    > I like these guidelines!
    >
    > What about relaxing our requirements on the number of votes required? Is a +1 and a +2A enough?

    I +2 often changes that I edited - and there I do like another +2 on them ;)

    Let's make one change at at time :)

    Andreas
    --
     Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
      SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
       GF: Felix Imendörffer, Jane Smithard, Graham Norton,
           HRB 21284 (AG Nürnberg)
        GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126




________________________________
Rackspace Limited is a company registered in England & Wales (company registered number 03897010) whose registered office is at 5 Millington Road, Hyde Park Hayes, Middlesex UB3 4AZ. Rackspace Limited privacy policy can be viewed at www.rackspace.co.uk/legal/privacy-policy - This e-mail message may contain confidential or privileged information intended for the recipient. Any dissemination, distribution or copying of the enclosed material is prohibited. If you receive this transmission in error, please notify us immediately by e-mail at abuse@xxxxxxxxxxxxx and delete the original message. Your cooperation is appreciated.

References