← Back to team overview

openstack team mailing list archive

Re: Review days for nova-core members


I'll throw my hat in the ring for core if deemed worthy. 

Soren's point about 1 review day per # core developers was refreshing. I had previously held back from applying because I was afraid all my time would be tied up with reviews.


From: openstack-bounces+sandy.walsh=rackspace.com@xxxxxxxxxxxxxxxxxxx [openstack-bounces+sandy.walsh=rackspace.com@xxxxxxxxxxxxxxxxxxx] on behalf of Thierry Carrez [thierry@xxxxxxxxxxxxx]
Sent: Thursday, February 17, 2011 10:26 AM
To: openstack@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Openstack] Review days for nova-core members

Soren Hansen wrote:
> That's really a corollary to this proposal: Being in nova-core means you have
> a review day once every N days (where N is the amount of (human) members of
> nova-core). As such, if you're not prepared to accept such a review day, you
> don't get to be part of the team. Simple.

That would definitely help in getting *all* branches reviewed, and
should be sufficient to clear the backlog.

If the number of branches pending review go above a certain level, maybe
we could switch temporarily to "double mode" where we get two -core
members on review duty every day.

For nova-core as an example, we currently have 18 people in the team, of
which I'd say 9 people are regular reviewers. If we can clean up and add
a few more members (~15) that would mean one review day every three
weeks in normal mode and one every 1.5 week in "double mode". Sounds
like a reasonable commitment.

That said that shouldn't prevent anyone from also reviewing stuff that
they care about any day.

Thierry Carrez (ttx)
Release Manager, OpenStack

Mailing list: https://launchpad.net/~openstack
Post to     : openstack@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~openstack
More help   : https://help.launchpad.net/ListHelp

Confidentiality Notice: This e-mail message (including any attached or
embedded documents) is intended for the exclusive and confidential use of the
individual or entity to which this message is addressed, and unless otherwise
expressly indicated, is confidential and privileged information of Rackspace.
Any dissemination, distribution or copying of the enclosed material is prohibited.
If you receive this transmission in error, please notify us immediately by e-mail
at abuse@xxxxxxxxxxxxx, and delete the original message.
Your cooperation is appreciated.

Follow ups