openstack team mailing list archive

[Brad Hall <brad@xxxxxxxxxx>]

I'm not sure about during an interactive rebase .. I've always just
done the amend before or after the rebase and the changeid will get
added if it isn't already there.

Thanks,
Brad

On Thu, Aug 4, 2011 at 9:16 AM, Trey Morris <trey.morris@xxxxxxxxxxxxx> wrote:
> I had to register my git email with gerrit as well, no problems after.
> If you do a "git commit --amend" will the hook add the change-id after you
> edit the commit message? I ask because it didn't when doing an interactive
> rebase. I did it this morning but I pasted the change-id in myself.
> -trey
>
> On Thu, Aug 4, 2011 at 10:40 AM, Brad Hall <brad@xxxxxxxxxx> wrote:
>>
>> If your commit doesn't have a change-id message you can add one by
>> amending the commit (git commit --amend) as long as you have the
>> commit-msg hook in place and executable. (See here for more details:
>> http://wiki.openstack.org/GerritWorkflow)  This page doesn't mention
>> it but you need to chmod +x the hook if it isn't already.
>>
>> Thanks,
>> Brad
>>
>> On Thu, Aug 4, 2011 at 2:44 AM, Yuriy Taraday <yorik.sar@xxxxxxxxx> wrote:
>> > Thanks to he fix, "invalid author" problem vanished.
>> > Now I'm getting "missing Change-Id in commit message" error.
>> > What is the best way to provide Change-Id to existing commits?
>> >
>> > Kind regards, Yuriy.
>> >
>> >
>> > On Wed, Aug 3, 2011 at 18:58, James E. Blair <corvus@xxxxxxxxxxxx>
>> > wrote:
>> >>
>> >> Yuriy Taraday <yorik.sar@xxxxxxxxx> writes:
>> >>
>> >> > Hello.
>> >> >
>> >> > I'm trying to use Gerrit to propose changes to Keystone.
>> >> > I'm using instructions from http://wiki.openstack.org/GerritWorkflow
>> >> > to
>> >> > push
>> >> > my changes.
>> >> > I'm getting "invalid author" error but my settings/contacts page
>> >> > looks
>> >> > fine
>> >> > and the e-mail listed there and in the error message are the same.
>> >> > What could go wrong?
>> >>
>> >> Hi,
>> >>
>> >> I don't think you did anything wrong.  It looks like we made a mistake
>> >> in importing account information from Launchpad.
>> >>
>> >> We try to import as much account information (name, ssh keys, email
>> >> addresses, etc.) from Launchpad as possible.  It looks like the email
>> >> address needs to be added to more than one location in the database.
>> >>
>> >> I believe I have fixed up your entry by hand (feel free to email me or
>> >> find me on IRC (jeblair)) if you still have problems.  I'll work on
>> >> updating our import script to fix the rest of the accounts and send out
>> >> another email to this list when that is complete.
>> >>
>> >> Thanks for helping us test this!
>> >>
>> >> -Jim
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~openstack
>> > Post to     : openstack@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~openstack
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>> >
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openstack
>> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openstack
>> More help   : https://help.launchpad.net/ListHelp
>
>