← Back to team overview

openstack team mailing list archive

Re: Gerrit minimum review time frame


Is this is really a problem that needs solving? I'd like to believe that no
member of Nova Core would approve something that they aren't familiar with.

IMHO, we should be making better attempts at not letting branches sit
around for days/weeks at a time.

On Mon, Mar 12, 2012 at 4:59 PM, Joe Gordon <jogo@xxxxxxxxxxxxxxxx> wrote:

> Hi All,
> I have noticed that some Gerrit branches get approved very quickly,
> sometimes in a matter of minutes.   While most of the time these branches
> are vetted properly, the window for reviewing can be so small that a
> non-trivial branch lands but without enough vetting.  If someone is in a
> meeting for half on hour they may miss the entire review window.  To fix
> this problem I propose a minimum time frame (should be overridable in an
> emergency) for a branch to be approved, perhaps 2 hours.  This time frame
> would start on 'Upload time.'
> best,
> Joe Gordon
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp

Follow ups