← Back to team overview

openstack team mailing list archive

Re: Gerrit minimum review time frame

 

2012/3/12 Josh Kearney <josh@xxxxxxx>:
> Is this is really a problem that needs solving? I'd like to believe
> that no member of Nova Core would approve something that they aren't
> familiar with.

That's not the point. The review process isn't just about finding enough
people who agree with your change, it's just as much (some might argue,
it's even more) about giving people a chance to *disagree*.

> IMHO, we should be making better attempts at not letting branches sit
> around for days/weeks at a time.

I agree. That's a completely separate issue, though.

-- 
Soren Hansen             | http://linux2go.dk/
Senior Software Engineer | http://www.cisco.com/
Ubuntu Developer         | http://www.ubuntu.com/
OpenStack Developer      | http://www.openstack.org/


References