← Back to team overview

openstack team mailing list archive

Re: [client] creating blueprints for the unified CLI project

 

>> I skipped out on blue printing and just submitted a gerrit review for
>> adding argparse flags for specifying URL for specific APIs.
>
> Why is this needed?  These URLs come from the service catalog.  Cases
> where you do need to override that use --os-url as part of token flow
> auth, skipping the service catalog.

I was thinking of edge cases where someone may want to target a query
to a specific api server.  Diagnostics stuff.  Maybe we don't want to
add this now.  Seemed simple enough though.  Might be too much detail
work.

>> Is that cool or do we want blue prints at that level of low complexity?
>
> There should be some sort of discussion for design changes/additions.
> Blueprints are a way to do that and record the discussion and
> target/track the work.  These discussions do happen in the Gerrit
> review comments too, but those are more reactive than proactive.

Okay.  I'll create a blue print.  Just seemed such a simple change we
could vote it up or down in gerrit directly.

> BTW, rather than abandon your initial change, you could have made the
> update, commited with 'git commit -a --amend' and push a new patchset
> with 'git review'.  As long as the change id in the log message
> doesn't change Gerrit does the Right Thing.  See the bottom of
> http://wiki.openstack.org/GerritWorkflow for details.

Yes, sorry about failing to amend.  Still getting acquainted with
gerrit.  Already been informed of that.


References