openstack team mailing list archive

[Leander Bessa Beernaert <leanderbb@xxxxxxxxx>]

I would like to add that I did not implement the test method, it was
already there. Also it supplies a different set of data than the one i
received when working with devstack.

Which of the data types should i assume to be correct, the one from
devstack or the one from the test?

On Mon, Jun 25, 2012 at 4:10 PM, Jay Pipes <jaypipes@xxxxxxxxx> wrote:

> You are not returning the data in the test method, whereas you are in the
> real method :)
>
> -jay
>
>
> On 06/25/2012 10:44 AM, Leander Bessa Beernaert wrote:
>
>> Sorry, forgot to add the code:
>>
>> *This is my method (this worked with devstack):*
>>
>>     def get_diagnostics(self, instance):
>>         dom = self._lookup_by_name(instance[**'name'])
>>         return diagnostics.get_diagnostics(**dom)
>>
>>
>> *and this the test method*:
>>
>>
>>  def test_get_diagnostics(self):
>>         instance_ref, network_info = self._get_running_instance()
>>         self.connection.get_**diagnostics(instance_ref['**name'])
>>
>> On Mon, Jun 25, 2012 at 3:41 PM, Leander Bessa Beernaert
>> <leanderbb@xxxxxxxxx <mailto:leanderbb@xxxxxxxxx>> wrote:
>>
>>    Hello,
>>
>>    I'm working on the diagnostics method for libvirt. I've
>>    successfully managed to test it while running it manually and with
>>    devstack. However, the test case in test_virt_drivers.py fails since
>>    it supplies a different data type to the method.
>>
>>    Could it be possible that there's a certain mismatch between the two
>>    or that this particular method accepts multiple sorts of data-types?
>>
>>    Regards,
>>    Leander
>>
>>
>>
>>
>> ______________________________**_________________
>> Mailing list: https://launchpad.net/~**openstack<https://launchpad.net/~openstack>
>> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~**openstack<https://launchpad.net/~openstack>
>> More help   : https://help.launchpad.net/**ListHelp<https://help.launchpad.net/ListHelp>
>>
>>
>
> ______________________________**_________________
> Mailing list: https://launchpad.net/~**openstack<https://launchpad.net/~openstack>
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~**openstack<https://launchpad.net/~openstack>
> More help   : https://help.launchpad.net/**ListHelp<https://help.launchpad.net/ListHelp>
>