← Back to team overview

oqgraph-dev team mailing list archive

Re: Regression test for attribute segfaults

 

Hi Andrew

> I'm converting your regression cases to a testsuite file.
> Pushing shortly.

Pushed. See mysql-test/suite/oqgraph/create_attr.test

Looks pretty awesome, you've done excellent work with the additional tests! well done.


I couldn't record a result file yet, as one of the error messages looks wrong:

CREATE TABLE oqtable ( latch SMALLINT UNSIGNED NULL, origid BIGINT UNSIGNED NULL, destid BIGINT UNSIGNED NULL, weight DOUBLE NULL, seq BIGINT UNSIGNED NULL, linkid BIGINT UNSIGNED NULL, KEY (latch, origid, destid) USING HASH, KEY (latch, destid, origid) USING HASH ) ENGINE=OQGRAPH, DATA_TABLE='backing',ORIGID='id',DESTID='id',WEIGHT='bogus';
DESCRIBE oqtable;

 ERROR HY000: Got error -1 'Invalid OQGRAPH backing store ('/oqtable'.weight attribute not set to a valid column of 'backing')' from OQGRAPH


Variable p in that case doesn't point to what you think it does.
Other than that it tests everything neatly. Note how I used the --error 1296 line for all these create statements to tell MTR that we are actually wanting to see a specific error (rather than aborting on it).


I also made a note on ORIGID='id' DESTID='id' which I think should actually fail as it can never be a valid scenario. Are you able to add a check for that in the code as well?


Cheers,
Arjen.
-- 
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com)
Australian peace of mind for your MySQL/MariaDB infrastructure.

Follow us at http://openquery.com/blog/ & http://twitter.com/openquery



References