oqgraph-dev team mailing list archive
-
oqgraph-dev team
-
Mailing list archive
-
Message #00292
Fwd: Re: Serious use after free bug
-
To:
oqgraph-dev@xxxxxxxxxxxxxxxxxxx
-
From:
Arjen Lentz <arjen@xxxxxxxxxxxxxxxx>
-
Date:
Wed, 18 Jun 2014 19:09:15 +1000
-
In-reply-to:
<53A15711.2000802@openquery.com.au>
-
Organization:
Open Query
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
Oops I intended to send to list.
Hi Andrew
Arjen Lentz <arjen@xxxxxxxxxxxxxxxx> wrote:
You may need some advice on how to ensure that when a connection closes,
things get cleaned up properly. We may have missed a hook of some sort.
You could also check this in another engine. Perhaps Federated, or
Spider, or CONNECT ?
On 18/06/14 19:03, Andrew McDonnell wrote:
From a very cursory look at federated it seems we dont have
`handler::disconnect()` so I'll probably start there.
Meantime in the medium term I think refactoring ha_oqgraph.cc
to look more like ha_federated would be a worthwhile activity
Federated is probably not the best example.
It's in the best case a fixed up version of something quite old.
Look at others also (CONNECT is the newest, but Spider also - and
perhaps TokuDB ?) and roughly document which we can then run by Serg and
others first.
This also provides the opportunity to get other people in the community
involved in some of the refactoring work, which has the advantage of
getting more people familiar with the codebase!
Regards,
Arjen.
--
Arjen Lentz, Exec.Director @ Open Query (http://openquery.com.au)
Australian peace of mind for your MySQL/MariaDB infrastructure.
Follow us http://openquery.com.au/blog/ & http://twitter.com/openquery
Follow ups