← Back to team overview

oship-dev team mailing list archive

Re: OSHIP Rev 224 Code Review: issue #03 - replace hard coded URLs by Grok generated URLs

 

On Tue, 2009-03-24 at 13:00 +0100, Roger Erens wrote:
> We have some hard coded URLs in the code of app.py
> 
> self.redirect("http://localhost:8080/oship";) # now simply redirect
> 
> This forces the users to add an application with the specific name
> 'oship', no typos or variations allowed.
> 
> To give the users the freedom to choose their own names, the hard coded
> URLs should be replaced by
> 
> self.redirect(self.url('index'))
> or
> self.redirect(self.application_url())

I agree with this one.  But some study of Zope3/Grok is required.

--Tim


-- 
Timothy Cook, MSc
Health Informatics Research & Development Services
LinkedIn Profile:http://www.linkedin.com/in/timothywaynecook 
Skype ID == timothy.cook 
**************************************************************
*You may get my Public GPG key from  popular keyservers or   *
*from this link http://timothywayne.cook.googlepages.com/home*
**************************************************************

Attachment: signature.asc
Description: This is a digitally signed message part


References