← Back to team overview

oship-dev team mailing list archive

OSHIP Rev 224 Code Review: issue #01 - unneeded imports in app.py

 

2009/3/24 Tim Cook <timothywayne.cook@xxxxxxxxx>

On Tue, 2009-03-24 at 11:45 +0100, Roger Erens wrote:
>
> > So here goes the first:
> >
> > app.py contains imports that are not needed/used:
> > from zope.app.container.btree import BTreeContainer
> > from zope.app.folder import Folder
>
> This is a PERFECT starter.
>
> It will give you experience with Launchpad and the code solution is
> easy.  Delete two lines in app.py, bzr commit-m "solved Rev 224 issue
> #1", bzr push <your branch>, update with the trunk and test again
> (though this is a no-brainer) and Propose a merge.
>
> --Tim


Somebody already choose this one? If not, I would like to pick this.

One question... I want to unconditionally sync my local branch with the main
branch of OSHIP. What is the command that I need to use for this?

Cheers
Eduardo

Follow ups

References