oship-dev team mailing list archive

Thread
Date

Re: OSHIP Rev 224 Code Review: issue #01 - unneeded imports in app.py

To: OSHIP-Dev <oship-dev@xxxxxxxxxxxxxxxxxxx>
From: Tim Cook <timothywayne.cook@xxxxxxxxx>
Date: Tue, 24 Mar 2009 15:25:10 -0300
In-reply-to: <49C8B9E6.1010106@e-s-c.biz>
Organization: Tim Cook
Reply-to: timothywayne.cook@xxxxxxxxx

On Tue, 2009-03-24 at 11:45 +0100, Roger Erens wrote:

> So here goes the first:
> 
> app.py contains imports that are not needed/used:
> from zope.app.container.btree import BTreeContainer
> from zope.app.folder import Folder

This is a PERFECT starter.  

It will give you experience with Launchpad and the code solution is
easy.  Delete two lines in app.py, bzr commit-m "solved Rev 224 issue
#1", bzr push <your branch>, update with the trunk and test again
(though this is a no-brainer) and Propose a merge.

--Tim

Attachment: signature.asc
Description: This is a digitally signed message part

References

OSHIP Rev 224 Code Review: issue #01 - unneeded imports in app.py
From: Roger Erens, 2009-03-24