← Back to team overview

oship-dev team mailing list archive

Re: Parameters of constructors in datastructure.py

 

Thank you, Diego and Tim for the answers.

Diego:
> Some of classes in data had an super classes that have mandatory attributes.
> Take a look at their and you'll find out why classes you are trying to use
> had more properties than you think.
> (...)
> It's a bit weird for me(I suppose for you too) a class might be a several
> attributes. When I saw classes like that I feel like something wrong, but in
> this case could be OK. Inheritance is the way choose by openEHR
> Specification to explain the connections between the concepts, mainly
> between the archetype layer and the reference layer.

Tim:
> They may well have been implemented poorly (by me) but probably because
> they are inherited attributes and should be overridden.  As I say
> though, the implementation may be incorrect.  Feel free to make them
> work correctly with the spec.

Yes, I found this strange be cause some classes have this behavior and
some other classes are implemented in accordance to the
specifications, even if the subclass the same superclass.
I implement them by specifications and make some tests to see if all works.


Diego:
> Ok. If I can, I'll glad to help. I thought an fast approach as I tried to
> explain, but I think we could change after to a better solution.

Thank you. :) And yes, I can see this circular importing is as a
behavior that appears in more places, so a better solution would help
in them all.

Cheers
Eduardo



Follow ups

References