← Back to team overview

oship-dev team mailing list archive

Re: Parameters of constructors in datastructure.py

 

Hi Eduardo,

Diego and I just discussed these issues. Ibelieve that he has solutions
and he will be directing a refactoring that takes OSHIP back to my
original packaging layout and then solves the circular import problems
at that point.

This should make the code more readable and maintainable.

Thanks  guys for your expertise.

I now return this thread to the real Python programmers.  :-)

Cheers,
Tim 

  
On Wed, 2010-06-30 at 10:11 -0300, Eduardo César wrote:
> Thank you, Diego and Tim for the answers.
> 
> Diego:
> > Some of classes in data had an super classes that have mandatory attributes.
> > Take a look at their and you'll find out why classes you are trying to use
> > had more properties than you think.
> > (...)
> > It's a bit weird for me(I suppose for you too) a class might be a several
> > attributes. When I saw classes like that I feel like something wrong, but in
> > this case could be OK. Inheritance is the way choose by openEHR
> > Specification to explain the connections between the concepts, mainly
> > between the archetype layer and the reference layer.
> 
> Tim:
> > They may well have been implemented poorly (by me) but probably because
> > they are inherited attributes and should be overridden.  As I say
> > though, the implementation may be incorrect.  Feel free to make them
> > work correctly with the spec.
> 
> Yes, I found this strange be cause some classes have this behavior and
> some other classes are implemented in accordance to the
> specifications, even if the subclass the same superclass.
> I implement them by specifications and make some tests to see if all works.
> 
> 
> Diego:
> > Ok. If I can, I'll glad to help. I thought an fast approach as I tried to
> > explain, but I think we could change after to a better solution.
> 
> Thank you. :) And yes, I can see this circular importing is as a
> behavior that appears in more places, so a better solution would help
> in them all.
> 
> Cheers
> Eduardo

-- 
***************************************************************
Timothy Cook, MSc

LinkedIn Profile:http://www.linkedin.com/in/timothywaynecook 
Skype ID == (upon request)
Academic.Edu Profile: http://uff.academia.edu/TimothyCook

You may get my Public GPG key from  popular keyservers or    
from this link http://timothywayne.cook.googlepages.com/home 

Attachment: signature.asc
Description: This is a digitally signed message part


References