oship-dev team mailing list archive
-
oship-dev team
-
Mailing list archive
-
Message #01175
[Bug 606383] [NEW] seemingly unnecessary assignments in the initializer of class Cluster
Public bug reported:
The following assignments in the initializer of class Cluster seems unnecessary since they are done in the initializer of the superclass, aren't they?
self.uid = uid
self.atnodeid = archetypeNodeId
self.name = name
self.atdetails = archetypeDetails
self.fdraudit = feederAudit
self.parent = parent
It seems that only self.items should be retained.
I think we should be consistent in the call to the superclass initializer:
Compare the call super(Cluster, self).__init__(uid, archetypeNodeId, name, archetypeDetails, feederAudit, links, parent)
in class Cluster
with the call Locatable.__init__(self, uid, archetypeNodeId, name, archetypeDetails, feederAudit, links)
in class Item.
** Affects: oship
Importance: Low
Status: New
** Changed in: oship
Milestone: None => 1.5
** Changed in: oship
Importance: Undecided => Low
--
seemingly unnecessary assignments in the initializer of class Cluster
https://bugs.launchpad.net/bugs/606383
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.
Status in Open Source Health Information Platform (OSHIP): New
Bug description:
The following assignments in the initializer of class Cluster seems unnecessary since they are done in the initializer of the superclass, aren't they?
self.uid = uid
self.atnodeid = archetypeNodeId
self.name = name
self.atdetails = archetypeDetails
self.fdraudit = feederAudit
self.parent = parent
It seems that only self.items should be retained.
I think we should be consistent in the call to the superclass initializer:
Compare the call super(Cluster, self).__init__(uid, archetypeNodeId, name, archetypeDetails, feederAudit, links, parent)
in class Cluster
with the call Locatable.__init__(self, uid, archetypeNodeId, name, archetypeDetails, feederAudit, links)
in class Item.
Follow ups
References