← Back to team overview

oship-dev team mailing list archive

[Bug 610984] [NEW] some issues in DvCount

 

Public bug reported:

It seems that it is not necessary to test for the type of magnitude in
the initializer.

The initializer lacks the magnitudeStatus argument and so does the
superclass initializer.


The methods compare ("<") and isStrictlyComparable are not implemented.

The methods add and subtract in DvAmount may be implemented by calling
the methods __add__ and __sub__ respectively.

The method negate should be defined in DvAmount.

It would be interesting to define a representation value for this class,
wouldn't it?

** Affects: oship
     Importance: High
         Status: New

** Changed in: oship
   Importance: Undecided => High

** Changed in: oship
    Milestone: None => 1.5

-- 
some issues in DvCount
https://bugs.launchpad.net/bugs/610984
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.

Status in Open Source Health Information Platform (OSHIP): New

Bug description:
It seems that it is not necessary to test for the type of magnitude in the initializer.	

The initializer lacks the magnitudeStatus argument and so does the superclass initializer.


The methods compare ("<") and isStrictlyComparable are not implemented.

The methods add and subtract in DvAmount may be implemented by calling the methods __add__ and __sub__ respectively.

The method negate should be defined in DvAmount.

It would be interesting to define a representation value for this class, wouldn't it?





Follow ups

References