oship-dev team mailing list archive

[Sergio Miranda Freire <sergio@xxxxxxxxxxxxxxx>]

Public bug reported:

Argument magnitudeStatus is missing in the initializer and in the call to the superclass initializer.
magnitude is an derived attribute, so it does not need to appear as an argument in the initializer. It should be assigned the correct value in seconds based on the value attribute.
It is necessary to make a thorough check on the validity of the value argument in the initialization, which means that valueValid invariant should be fully implemented.

DvDuration inherits from DvAmount and ISO8601Duration (support package). So it is necessary to implement all methods of both classes, namely:
      add, subtract, negate, compare, isStrictlyComparableTo (DvAmount)
     asString, years, months, weeks, days, hours, minutes, seconds, fractionalSecond, is_decimal_sign_comma, toSeconds (ISO8601Duration)

** Affects: oship
     Importance: High
         Status: New

** Changed in: oship
   Importance: Undecided => High

** Changed in: oship
    Milestone: None => 1.5

-- 
several issues in DvDuration
https://bugs.launchpad.net/bugs/612572
You received this bug notification because you are a member of OSHIP
Development Team, which is subscribed to Open Source Health Information
Platform.

Status in Open Source Health Information Platform (OSHIP): New

Bug description:
Argument magnitudeStatus is missing in the initializer and in the call to the superclass initializer.
magnitude is an derived attribute, so it does not need to appear as an argument in the initializer. It should be assigned the correct value in seconds based on the value attribute.
It is necessary to make a thorough check on the validity of the value argument in the initialization, which means that valueValid invariant should be fully implemented.

DvDuration inherits from DvAmount and ISO8601Duration (support package). So it is necessary to implement all methods of both classes, namely:
      add, subtract, negate, compare, isStrictlyComparableTo (DvAmount)
     asString, years, months, weeks, days, hours, minutes, seconds, fractionalSecond, is_decimal_sign_comma, toSeconds (ISO8601Duration)